Code coverage ignore

Consider removing UserController
This commit is contained in:
Matt Young 2025-07-04 15:23:21 -05:00
parent db34a86545
commit c22f3ddadf
2 changed files with 40 additions and 83 deletions

View File

@ -9,81 +9,37 @@ use Illuminate\Support\Facades\Auth;
use function abort;
use function redirect;
class UserController extends Controller
{
/**
* Display a listing of the resource.
*/
public function index()
{
//
}
/**
* Show the form for creating a new resource.
*/
public function create()
{
//
}
/**
* Store a newly created resource in storage.
*/
public function store(Request $request)
{
//
}
/**
* Display the specified resource.
*/
public function show(User $user)
{
//
}
/**
* Show the form for editing the specified resource.
*/
public function edit(User $user)
{
//
}
/**
* Update the specified resource in storage.
*/
public function update(Request $request, User $user)
{
if ($user->id !== Auth::user()->id) {
return redirect()->route('dashboard')->with('error', 'You can only modify your own profile');
}
dd($request->all());
}
/**
* Remove the specified resource from storage.
*/
public function destroy(User $user)
{
//
}
public function set_school(Request $request, User $user)
{
if ($request->user()->cannot('set_school', $user)) {
abort(403);
}
request()->validate([
'school_id' => ['required', 'integer', 'exists:schools,id'],
]);
$user->update([
'school_id' => request('school_id'),
]);
return redirect('/my_school');
}
}
/**
* @codeCoverageIgnore
*/
// TODO consider for removal
//class UserController extends Controller
//{
// /**
// * Update the specified resource in storage.
// */
// public function update(Request $request, User $user)
// {
// if ($user->id !== Auth::user()->id) {
// return redirect()->route('dashboard')->with('error', 'You can only modify your own profile');
// }
// dd($request->all());
// }
//
// public function set_school(Request $request, User $user)
// {
// if ($request->user()->cannot('set_school', $user)) {
// abort(403);
// }
//
// request()->validate([
// 'school_id' => ['required', 'integer', 'exists:schools,id'],
// ]);
//
// $user->update([
// 'school_id' => request('school_id'),
// ]);
//
// return redirect('/my_school');
// }
//}

View File

@ -28,11 +28,12 @@ Route::middleware([
Route::delete('/entries/{entry}', 'destroy')->name('entries.destroy');
});
// User Related Routes
Route::middleware(['auth', 'verified'])->controller(UserController::class)->group(function () {
Route::patch('/users/{user}/set_school', 'set_school')->name('users.set_school');
Route::patch('/user_profile/{$user}', 'update')->name('users.update');
});
//// User Related Routes
//// TODO: Consider this block for removal
//Route::middleware(['auth', 'verified'])->controller(UserController::class)->group(function () {
// Route::patch('/users/{user}/set_school', 'set_school')->name('users.set_school');
// Route::patch('/user_profile/{$user}', 'update')->name('users.update');
//});
// Student Related Routes
Route::middleware([