From df561164be6333613633198bec99dea18e1d5cfd Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Fri, 5 Jul 2024 11:38:50 -0500
Subject: [PATCH] ScoringGuideIndex Tests

---
 .../Admin/ScoringGuideController.php          |  7 +-
 ...nsure_room_id_0_for_unassigned_entries.php |  7 +-
 ...ing_guide_id_column_to_auditions_table.php |  5 +-
 ...ex-scoring-guide-management-card.blade.php |  6 +-
 .../Pages/Setup/ScoringGuideIndexTest.php     | 85 +++++++++++++++++++
 5 files changed, 94 insertions(+), 16 deletions(-)
 create mode 100644 tests/Feature/Pages/Setup/ScoringGuideIndexTest.php

diff --git a/app/Http/Controllers/Admin/ScoringGuideController.php b/app/Http/Controllers/Admin/ScoringGuideController.php
index e07b1f7..0e84a5c 100644
--- a/app/Http/Controllers/Admin/ScoringGuideController.php
+++ b/app/Http/Controllers/Admin/ScoringGuideController.php
@@ -17,13 +17,10 @@ class ScoringGuideController extends Controller
 {
     public function index()
     {
-        if (! Auth::user()->is_admin) {
-            abort(403);
-        }
         DB::table('auditions')
             ->whereNull('scoring_guide_id')
             ->update(['scoring_guide_id' => 0]);
-        $guides = ScoringGuide::with('auditions')->orderBy('name')->get();
+        $guides = ScoringGuide::with(['auditions'])->withCount('subscores')->orderBy('name')->get();
 
         return view('admin.scoring.index', ['guides' => $guides]);
     }
@@ -42,7 +39,7 @@ class ScoringGuideController extends Controller
             'name' => request('name'),
         ]);
 
-        return redirect('/admin/scoring');
+        return redirect(route('admin.scoring.index'))->with('success', 'Scoring guide created');
     }
 
     public function edit(Request $request, ScoringGuide $guide)
diff --git a/database/migrations/2024_06_04_205015_ensure_room_id_0_for_unassigned_entries.php b/database/migrations/2024_06_04_205015_ensure_room_id_0_for_unassigned_entries.php
index 1c28c98..c2e0ac5 100644
--- a/database/migrations/2024_06_04_205015_ensure_room_id_0_for_unassigned_entries.php
+++ b/database/migrations/2024_06_04_205015_ensure_room_id_0_for_unassigned_entries.php
@@ -1,10 +1,7 @@
 <?php
 
 use App\Models\Room;
-use App\Models\ScoringGuide;
 use Illuminate\Database\Migrations\Migration;
-use Illuminate\Database\Schema\Blueprint;
-use Illuminate\Support\Facades\Schema;
 
 return new class extends Migration
 {
@@ -16,10 +13,10 @@ return new class extends Migration
         if (! Room::find(0)) {
             $room = Room::create([
                 'id' => 0,
-                'name' => 'No Guide Assigned'
+                'name' => 'No Guide Assigned',
             ]);
             $room->update([
-                'id' => 0
+                'id' => 0,
             ]);
         }
     }
diff --git a/database/migrations/2024_06_05_011858_add_scoring_guide_id_column_to_auditions_table.php b/database/migrations/2024_06_05_011858_add_scoring_guide_id_column_to_auditions_table.php
index c1f7640..c66e6ee 100644
--- a/database/migrations/2024_06_05_011858_add_scoring_guide_id_column_to_auditions_table.php
+++ b/database/migrations/2024_06_05_011858_add_scoring_guide_id_column_to_auditions_table.php
@@ -1,6 +1,5 @@
 <?php
 
-use App\Models\Room;
 use App\Models\ScoringGuide;
 use Illuminate\Database\Migrations\Migration;
 use Illuminate\Database\Schema\Blueprint;
@@ -20,10 +19,10 @@ return new class extends Migration
         if (! ScoringGuide::find(0)) {
             $sg = ScoringGuide::create([
                 'id' => 0,
-                'name' => 'No Guide Assigned'
+                'name' => 'No Guide Assigned',
             ]);
             $sg->update([
-                'id' => 0
+                'id' => 0,
             ]);
         }
     }
diff --git a/resources/views/admin/scoring/index-scoring-guide-management-card.blade.php b/resources/views/admin/scoring/index-scoring-guide-management-card.blade.php
index 8a57ab3..851cef3 100644
--- a/resources/views/admin/scoring/index-scoring-guide-management-card.blade.php
+++ b/resources/views/admin/scoring/index-scoring-guide-management-card.blade.php
@@ -17,14 +17,14 @@
                     @continue
                 @endif
                 <tr>
-                    <x-table.td>{{ $guide->name }}  <span class="text-xs text-gray-400">{{ $guide->subscores->count() }} subscores</span></x-table.td>
-                    <x-table.td class="text-right text-indigo-600"><a href="/admin/scoring/guides/{{ $guide->id }}/edit">Edit</a></x-table.td>
+                    <x-table.td>{{ $guide->name }}  <span class="text-xs text-gray-400">{{ $guide->subscores_count }} subscores</span></x-table.td>
+                    <x-table.td class="text-right text-indigo-600"><a href="{{ route('admin.scoring.edit', $guide) }}">Edit</a></x-table.td>
                 </tr>
             @endforeach
         </x-table.body>
         <tfoot>
         <tr>
-            <x-form.form method="POST" action="/admin/scoring/guides" class="!px-0 !py-0">
+            <x-form.form method="POST" action="{{ route('admin.scoring.store') }}" class="!px-0 !py-0">
                 <x-table.td>
                     <x-form.field name="name" label_text="Add New Scoring Guide" />
                 </x-table.td>
diff --git a/tests/Feature/Pages/Setup/ScoringGuideIndexTest.php b/tests/Feature/Pages/Setup/ScoringGuideIndexTest.php
new file mode 100644
index 0000000..92368f2
--- /dev/null
+++ b/tests/Feature/Pages/Setup/ScoringGuideIndexTest.php
@@ -0,0 +1,85 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\ScoringGuide;
+use App\Models\SubscoreDefinition;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Sinnbeck\DomAssertions\Asserts\AssertElement;
+
+use function Pest\Laravel\get;
+use function Pest\Laravel\post;
+
+uses(RefreshDatabase::class);
+
+it('shows a scoring guide management page only to administrators', function () {
+    get(route('admin.scoring.index'))
+        ->assertRedirect(route('home'));
+    actAsNormal();
+    get(route('admin.scoring.index'))
+        ->assertRedirect(route('dashboard'))
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+    actAsAdmin();
+    get(route('admin.scoring.index'))
+        ->assertOk()
+        ->assertViewIs('admin.scoring.index');
+});
+it('shows a list of scoring guides and their count of subscores', function () {
+    $scoringGuide = ScoringGuide::factory()->create();
+    SubscoreDefinition::factory()->count(3)->create(['scoring_guide_id' => $scoringGuide->id]);
+    Audition::factory()->count(3)->create(['scoring_guide_id' => $scoringGuide->id]);
+    actAsAdmin();
+    $response = get(route('admin.scoring.index'));
+    $response->assertOk()
+        ->assertSeeInOrder(['<td', $scoringGuide->name, $scoringGuide->subscores()->count()], false);
+});
+it('shows a link to edit each scoring guide', function () {
+    $scoringGuide = ScoringGuide::factory()->create();
+    actAsAdmin();
+    $response = get(route('admin.scoring.index'));
+    $response->assertOk()
+        ->assertSee(route('admin.scoring.edit', $scoringGuide));
+});
+it('shows auditions in groups with their scoring guide', function () {
+    $guides = ScoringGuide::factory()->count(2)->create();
+    foreach ($guides as $guide) {
+        Audition::factory()->count(3)->create(['scoring_guide_id' => $guide->id]);
+    }
+    actAsAdmin();
+    $response = get(route('admin.scoring.index'));
+    $response->assertOk();
+    foreach (Audition::all() as $audition) {
+        $guide = $audition->scoringGuide;
+        $response->assertElementExists('#guide-'.$guide->id, function (AssertElement $element) use ($audition) {
+            $element->containsText($audition->name);
+        });
+    }
+});
+it('has a form for a new scoring guide', function () {
+    actAsAdmin();
+    $response = get(route('admin.scoring.index'));
+    $response->assertOk()
+        ->assertSeeInOrder(['<input', 'name=', 'name'], false)
+        ->assertSee(route('admin.scoring.store'));
+});
+it('creates a new scoring guide', function () {
+    $formData = ['name' => 'New Scoring Guide'];
+    actAsAdmin();
+    $response = post(route('admin.scoring.store'), $formData);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response
+        ->assertSessionHasNoErrors()
+        ->assertRedirect(route('admin.scoring.index'))
+        ->assertSessionHas('success', 'Scoring guide created');
+    $this->assertDatabaseHas('scoring_guides', $formData);
+});
+it('only allows an admin to create a new scoring guide', function () {
+    // Arrange
+    $formData = ['name' => 'New Scoring Guide'];
+    // Act & Assert
+    $response = post(route('admin.scoring.store'), $formData);
+    $response->assertRedirect(route('home'));
+    actAsNormal();
+    $response = post(route('admin.scoring.store'), $formData);
+    $response->assertRedirect(route('dashboard'))
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+});